David Hayter is awesome, loved the guys work since The Guyver. MGS has probably some of the best voice acting along a series, very well scripted. I think having those codec moments is absolutely awesome. Check out MGS3 when you're in the cell, go to sleep and play the vampire killer game, then talk to Sigint after. One of the funniest things I've ever listened to in a game, apart from the box conversation.
And I have to agree that where I hate Tidus gotta admit there is a lot of class everywhere else. They did a very good job I think on Dissidia. I adore the voice acting in that game. Square really went all out to create something magical there and the voice acting is just the icing on the cake.
Also for voice acting, an acquired taste, I'd say Duke Nukem is a winner. I love those games and those cheesy one liners are fantastic, they're of Evil Dead quality.